From mboxrd@z Thu Jan 1 00:00:00 1970 From: akpm@osdl.org Subject: [patch 3/6] jfs_setattr() fix Date: Sat, 26 Jun 2004 15:00:33 -0700 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <200406262201.i5QM1SZ06666@mail.osdl.org> Cc: shaggy@austin.ibm.com, sfrench@us.ibm.com, vandrove@vc.cvut.cz, zippel@linux-m68k.org, agruen@suse.de, linux-fsdevel@vger.kernel.org, akpm@osdl.org Return-path: Received: from fw.osdl.org ([65.172.181.6]:64651 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S266463AbUFZWCW (ORCPT ); Sat, 26 Jun 2004 18:02:22 -0400 To: mason@suse.com List-Id: linux-fsdevel.vger.kernel.org jfs is dropping inode_setattr()'s return value. Signed-off-by: Andrew Morton --- 25-akpm/fs/jfs/acl.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN fs/jfs/acl.c~jfs_setattr-fix fs/jfs/acl.c --- 25/fs/jfs/acl.c~jfs_setattr-fix 2004-06-26 14:41:27.039360304 -0700 +++ 25-akpm/fs/jfs/acl.c 2004-06-26 14:41:39.249504080 -0700 @@ -281,9 +281,9 @@ int jfs_setattr(struct dentry *dentry, s if (rc) return rc; - inode_setattr(inode, iattr); + rc = inode_setattr(inode, iattr); - if (iattr->ia_valid & ATTR_MODE) + if (!rc && (iattr->ia_valid & ATTR_MODE)) rc = jfs_acl_chmod(inode); return rc; _