* [patch 4/6] cifs_setattr() retval fix
@ 2004-06-26 22:00 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2004-06-26 22:00 UTC (permalink / raw)
To: mason; +Cc: shaggy, sfrench, vandrove, zippel, agruen, linux-fsdevel, akpm
CIFS is failing to propagate the inode_setattr() return value.
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
25-akpm/fs/cifs/inode.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
diff -puN fs/cifs/inode.c~cifs_setattr-retval-fix fs/cifs/inode.c
--- 25/fs/cifs/inode.c~cifs_setattr-retval-fix 2004-06-26 14:42:54.386081584 -0700
+++ 25-akpm/fs/cifs/inode.c 2004-06-26 14:43:16.864664320 -0700
@@ -954,7 +954,8 @@ cifs_setattr(struct dentry *direntry, st
}
/* do not need local check to inode_check_ok since the server does that */
- inode_setattr(direntry->d_inode, attrs);
+ if (!rc)
+ rc = inode_setattr(direntry->d_inode, attrs);
if (full_path)
kfree(full_path);
FreeXid(xid);
_
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-06-26 22:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-26 22:00 [patch 4/6] cifs_setattr() retval fix akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).