Re: [Jfs-patches] [PATCH] Add d_hash and d_compare operations for case-insensitive names (1 of 1)

Re: [Jfs-patches] [PATCH] Add d_hash and d_compare operations for case-insensitive names (1 of 1)

[Christoph Hellwig]

> -	return d_splice_alias(ip, dentry);
> +	if (JFS_SBI(dip->i_sb)->mntflag & JFS_OS2)
> +		dentry->d_op = &jfs_ci_dentry_operations;
> +
> +	dentry = d_splice_alias(ip, dentry);
> +
> +	if (dentry && (JFS_SBI(dip->i_sb)->mntflag & JFS_OS2))
> +		dentry->d_op = &jfs_ci_dentry_operations;A

If d_splice_alias doesn't propagate d_ops it needs to be fixed, not worked around.

> +	memcpy((unsigned char *)a->name, b->name, a->len);

why do you need this cast?

Re: [PATCH] Add d_hash and d_compare operations for case-insensitive names (1 of 1)

[Dave Kleikamp]

On Mon, 2004-07-12 at 13:43, Christoph Hellwig wrote:
> > -	return d_splice_alias(ip, dentry);
> > +	if (JFS_SBI(dip->i_sb)->mntflag & JFS_OS2)
> > +		dentry->d_op = &jfs_ci_dentry_operations;
> > +
> > +	dentry = d_splice_alias(ip, dentry);
> > +
> > +	if (dentry && (JFS_SBI(dip->i_sb)->mntflag & JFS_OS2))
> > +		dentry->d_op = &jfs_ci_dentry_operations;A
> 
> If d_splice_alias doesn't propagate d_ops it needs to be fixed, not worked around.

I didn't realize this was a work-around.  This is where other file
systems set d_op.

> > +	memcpy((unsigned char *)a->name, b->name, a->len);
> 
> why do you need this cast?

qstr defines ->name as const.  Without the cast, the compiler
complains.  Modifying a->name is kind of ugly, but it make case
preservation work.
-- 
David Kleikamp
IBM Linux Technology Center

Re: [Jfs-patches] [PATCH] Add d_hash and d_compare operations for case-insensitive names (1 of 1)

[Jan Kratochvil]

Hi,

On Mon, 12 Jul 2004 20:55:53 +0200, Dave Kleikamp wrote:
> On Mon, 2004-07-12 at 13:43, Christoph Hellwig wrote:
...
> > > +	memcpy((unsigned char *)a->name, b->name, a->len);
> > 
> > why do you need this cast?
> 
> qstr defines ->name as const.  Without the cast, the compiler
> complains.  Modifying a->name is kind of ugly, but it make case
> preservation work.

It looks as the same issues being dealt with in my case-preserving
case-insensitive patch for vfat+affs some years ago. It never made it to
kernel.
	http://www.jankratochvil.net/priv/vfat/

(Jan Kara coauthored)


Regards,
Lace

-- 
Jan Kratochvil; Captive: free r/w NTFS Filesystem; http://www.jankratochvil.net/

Re: [Jfs-patches] [PATCH] Add d_hash and d_compare operations for case-insensitive names (1 of 1)

[Dave Kleikamp]

On Tue, 2004-07-13 at 00:28, Jan Kratochvil wrote:
> It looks as the same issues being dealt with in my case-preserving
> case-insensitive patch for vfat+affs some years ago. It never made it to
> kernel.
> 	http://www.jankratochvil.net/priv/vfat/
> 
> (Jan Kara coauthored)

What I do is much less sophisticated.  This patch will not allow a
rename that only changes the case of a name.  The memcpy just makes sure
that when a new entry is created, the existence of a previous negative
dentry doesn't affect the case of the new entry.

Is there still any interest in getting your patch into the kernel?

> Regards,
> Lace

Shaggy
-- 
David Kleikamp
IBM Linux Technology Center