From: Andrew Morton <akpm@osdl.org>
To: Matthew Wilcox <willy@debian.org>
Cc: torvalds@osdl.org, akpm@zip.com.au,
linux-fsdevel@vger.kernel.org, smfrench@austin.rr.com,
trond.myklebust@fys.uio.no
Subject: Re: [PATCH] Remove fcntl f_op
Date: Sat, 14 Aug 2004 23:39:06 -0700 [thread overview]
Message-ID: <20040814233906.0df76f12.akpm@osdl.org> (raw)
In-Reply-To: <20040812221229.GH12936@parcelfarce.linux.theplanet.co.uk>
Matthew Wilcox <willy@debian.org> wrote:
>
> The newly introduced ->fcntl file_operation is badly thought out,
Not really - it's very simple.
> not to mention undocumented.
That's because it's simple.
> This patch replaces it with two better
> defined operations -- check_flags and dir_notify.
Except these _do_ need to be documented, and you didn't do that.
Seems like a fairly pointless patch to me but whatever - it's a trivial
matter. Please send an updated patch which documents the new API.
next prev parent reply other threads:[~2004-08-15 6:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-12 22:12 [PATCH] Remove fcntl f_op Matthew Wilcox
2004-08-12 22:22 ` viro
2004-08-15 6:39 ` Andrew Morton [this message]
2004-08-15 12:52 ` Matthew Wilcox
2004-08-15 17:43 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040814233906.0df76f12.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=akpm@zip.com.au \
--cc=linux-fsdevel@vger.kernel.org \
--cc=smfrench@austin.rr.com \
--cc=torvalds@osdl.org \
--cc=trond.myklebust@fys.uio.no \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).