From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] Remove fcntl f_op Date: Sat, 14 Aug 2004 23:39:06 -0700 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20040814233906.0df76f12.akpm@osdl.org> References: <20040812221229.GH12936@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: torvalds@osdl.org, akpm@zip.com.au, linux-fsdevel@vger.kernel.org, smfrench@austin.rr.com, trond.myklebust@fys.uio.no Return-path: Received: from fw.osdl.org ([65.172.181.6]:59830 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S266508AbUHOGlG (ORCPT ); Sun, 15 Aug 2004 02:41:06 -0400 To: Matthew Wilcox In-Reply-To: <20040812221229.GH12936@parcelfarce.linux.theplanet.co.uk> List-Id: linux-fsdevel.vger.kernel.org Matthew Wilcox wrote: > > The newly introduced ->fcntl file_operation is badly thought out, Not really - it's very simple. > not to mention undocumented. That's because it's simple. > This patch replaces it with two better > defined operations -- check_flags and dir_notify. Except these _do_ need to be documented, and you didn't do that. Seems like a fairly pointless patch to me but whatever - it's a trivial matter. Please send an updated patch which documents the new API.