From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: [PATCH] remove dead code from fs/mbcache.c Date: Tue, 7 Sep 2004 16:33:08 +0200 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20040907143308.GA8396@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org Return-path: Received: from verein.lst.de ([213.95.11.210]:20633 "EHLO mail.lst.de") by vger.kernel.org with ESMTP id S268120AbUIGOdN (ORCPT ); Tue, 7 Sep 2004 10:33:13 -0400 To: akpm@osdl.org, agruen@suse.de Content-Disposition: inline List-Id: linux-fsdevel.vger.kernel.org mb_cache_entry_takeout and mb_cache_entry_dup are totally unused. --- 1.5/fs/mbcache.c 2003-05-25 23:07:56 +02:00 +++ edited/fs/mbcache.c 2004-09-07 15:13:57 +02:00 @@ -65,9 +65,7 @@ EXPORT_SYMBOL(mb_cache_entry_alloc); EXPORT_SYMBOL(mb_cache_entry_insert); EXPORT_SYMBOL(mb_cache_entry_release); -EXPORT_SYMBOL(mb_cache_entry_takeout); EXPORT_SYMBOL(mb_cache_entry_free); -EXPORT_SYMBOL(mb_cache_entry_dup); EXPORT_SYMBOL(mb_cache_entry_get); #if !defined(MB_CACHE_INDEXES_COUNT) || (MB_CACHE_INDEXES_COUNT > 0) EXPORT_SYMBOL(mb_cache_entry_find_first); @@ -456,23 +454,6 @@ /* - * mb_cache_entry_takeout() - * - * Take a cache entry out of the cache, making it invalid. The entry can later - * be re-inserted using mb_cache_entry_insert(), or released using - * mb_cache_entry_release(). - */ -void -mb_cache_entry_takeout(struct mb_cache_entry *ce) -{ - spin_lock(&mb_cache_spinlock); - mb_assert(list_empty(&ce->e_lru_list)); - __mb_cache_entry_unhash(ce); - spin_unlock(&mb_cache_spinlock); -} - - -/* * mb_cache_entry_free() * * This is equivalent to the sequence mb_cache_entry_takeout() -- @@ -485,20 +466,6 @@ mb_assert(list_empty(&ce->e_lru_list)); __mb_cache_entry_unhash(ce); __mb_cache_entry_release_unlock(ce); -} - - -/* - * mb_cache_entry_dup() - * - * Duplicate a handle to a cache entry (does not duplicate the cache entry - * itself). After the call, both the old and the new handle must be released. - */ -struct mb_cache_entry * -mb_cache_entry_dup(struct mb_cache_entry *ce) -{ - atomic_inc(&ce->e_used); - return ce; } --- 1.2/include/linux/mbcache.h 2002-11-14 23:03:01 +01:00 +++ edited/include/linux/mbcache.h 2004-09-07 15:14:04 +02:00 @@ -56,9 +56,7 @@ sector_t, unsigned int[]); void mb_cache_entry_rehash(struct mb_cache_entry *, unsigned int[]); void mb_cache_entry_release(struct mb_cache_entry *); -void mb_cache_entry_takeout(struct mb_cache_entry *); void mb_cache_entry_free(struct mb_cache_entry *); -struct mb_cache_entry *mb_cache_entry_dup(struct mb_cache_entry *); struct mb_cache_entry *mb_cache_entry_get(struct mb_cache *, struct block_device *, sector_t);