linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "William A.(Andy) Adamson" <andros@citi.umich.edu>
To: linux-fsdevel@vger.kernel.org
Cc: andros@citi.umich.edu
Subject: PATCH [7/10] lease interfaces for version 4 NFSD
Date: Mon, 20 Sep 2004 16:23:03 -0400	[thread overview]
Message-ID: <20040920202303.53FD51BBAA@citi.umich.edu> (raw)

[-- Attachment #1: Type: text/plain, Size: 121 bytes --]

VFS: use the inode i_writecount to test for handing out a F_RDLCK lease


Signed-off-by: Andy Adamson <andros@umich.edu>

[-- Attachment #2: linux-2.6.9-rc2-07-setlease-fixme.dif --]
[-- Type: text/plain , Size: 600 bytes --]

diff --recursive -puN old/fs/locks.c new/fs/locks.c
--- old/fs/locks.c	2004-09-20 13:56:25.385316000 -0400
+++ new/fs/locks.c	2004-09-20 14:15:31.144266000 -0400
@@ -1275,10 +1275,10 @@ int __setlease(struct file *filp, long a
 	if (!flp || !(*flp) || !(*flp)->fl_lmops || !(*flp)->fl_lmops->fl_break)
 		goto out;
 
-	/*
-	 * FIXME: What about F_RDLCK and files open for writing?
-	 */
 	error = -EAGAIN;
+	if ((arg == F_RDLCK) && (atomic_read(&inode->i_writecount) > 0))
+		goto out;
+
 	if ((arg == F_WRLCK)
 	    && ((atomic_read(&dentry->d_count) > 1)
 		|| (atomic_read(&inode->i_count) > 1)))

                 reply	other threads:[~2004-09-20 20:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040920202303.53FD51BBAA@citi.umich.edu \
    --to=andros@citi.umich.edu \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).