Re: PATCH [6/10] lease interfaces for version 4 NFSD

["William A.(Andy) Adamson" <andros@citi.umich.edu>]

> On Mon, Sep 20, 2004 at 04:23:00PM -0400, William A.(Andy) Adamson wrote:
> > +	locks_init_lock(&fl);
> > +        if ((error = lease_init(filp, arg, &fl)))
> > +                return error;
> > +	lock_kernel();
> > +	if((error = __setlease(filp, arg, &flp)))
> > +		goto out;
> > +
> 
> Please follow kernel coding style.  That means:

ok. 

BTW: i just noted that there are two emails with PATCH [9/10] in the title. 
they are different patches...

-->Andy


>  - Tabs, not spaces for indentation.
>  - No assignment within if ()
>  - Space between if and (
> ie write this bit as:
> 
> 	locks_init_lock(&fl);
> 	error = lease_init(filp, arg, &fl);
> 	if (error)
> 		return error;
> 	lock_kernel();
> 	error = __setlease(filp, arg, &flp);
> 	if (error)
> 		goto out;
> 
> >  	return error;
> >  }
> >  
> > +
> >  /**
> >   * flock_lock_file_wait - Apply a FLOCK-style lock to a file
> >   * @filp: The file to apply the lock to
> 
> Don't put this additional line in.  I don't like it.
> 
> -- 
> "Next the statesmen will invent cheap lies, putting the blame upon 
> the nation that is attacked, and every man will be glad of those
> conscience-soothing falsities, and will diligently study them, and refuse
> to examine any refutations of them; and thus he will by and by convince 
> himself that the war is just, and will thank God for the better sleep 
> he enjoys after this process of grotesque self-deception." -- Mark Twain
>