From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: fishy ->put_inode usage in ntfs Date: Thu, 14 Oct 2004 13:26:07 +0200 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20041014112607.GA24508@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-ntfs-dev@lists.sourceforge.net, linux-fsdevel@vger.kernel.org Return-path: Received: from verein.lst.de ([213.95.11.210]:1004 "EHLO mail.lst.de") by vger.kernel.org with ESMTP id S261426AbUJNL0P (ORCPT ); Thu, 14 Oct 2004 07:26:15 -0400 To: aia21@cantab.net Content-Disposition: inline List-Id: linux-fsdevel.vger.kernel.org Hi Anton, the inode->i_count useage in ntfs_put_inode is possibly ract vecause we could get anoher reference while you're looking at it. For the index inode case moving this to clear_inode (which is called after we released the last reference) should be fine, but I don't understand the case for directories - why are you checking for i_count beeing 2 there and not one?