From: Christoph Hellwig <hch@lst.de>
To: zippel@linux-m68k.org
Cc: linux-fsdevel@vger.kernel.org
Subject: fishy ->put_inode usage in affs
Date: Thu, 14 Oct 2004 13:30:05 +0200 [thread overview]
Message-ID: <20041014113005.GA24568@lst.de> (raw)
looking at i_count in ->put_inode is racy. But ou could do the truncate
nicely in ->clear_inode, with some work you might be able to consolidate
the affs_truncate call in affs_delete_inode into that one aswell.
Also what's the rationale for discarding the preallocations in
affs_put_inode? Inode reference counts are something purely internal,
depending in whether it's in core or ondisk reservations either
fops->release or iops->clear_inode sounds like the right thing for it.
next reply other threads:[~2004-10-14 11:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-14 11:30 Christoph Hellwig [this message]
2004-10-14 20:23 ` fishy ->put_inode usage in affs Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041014113005.GA24568@lst.de \
--to=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).