From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@lst.de>
Subject: fishy ->put_inode usage in affs
Date: Thu, 14 Oct 2004 13:30:05 +0200
Sender: linux-fsdevel-owner@vger.kernel.org
Message-ID: <20041014113005.GA24568@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.210]:8172 "EHLO mail.lst.de")
	by vger.kernel.org with ESMTP id S261724AbUJNLaI (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 14 Oct 2004 07:30:08 -0400
To: zippel@linux-m68k.org
Content-Disposition: inline
List-Id: linux-fsdevel.vger.kernel.org

looking at i_count in ->put_inode is racy.  But ou could do the truncate
nicely in ->clear_inode, with some work you might be able to consolidate
the affs_truncate call in affs_delete_inode into that one aswell.

Also what's the rationale for discarding the preallocations in
affs_put_inode?  Inode reference counts are something purely internal,
depending in whether it's in core or ondisk reservations either
fops->release or iops->clear_inode sounds like the right thing for it.