linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Anton Altaparmakov <aia21@cam.ac.uk>
Cc: Christoph Hellwig <hch@lst.de>,
	aia21@cantab.net, ntfs-dev <linux-ntfs-dev@lists.sourceforge.net>,
	linux-fsdevel@vger.kernel.org
Subject: Re: fishy ->put_inode usage in ntfs
Date: Thu, 14 Oct 2004 13:44:00 +0100	[thread overview]
Message-ID: <20041014124400.GL16153@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <1097757569.21275.40.camel@imp.csi.cam.ac.uk>

On Thu, Oct 14, 2004 at 01:39:30PM +0100, Anton Altaparmakov wrote:
> Hm, I can now see that there is a small race window here and this is
> simply fixed by doing the setting to NULL of bmp_ino before doing the
> iput() of bmp_ino.  Thanks for pointing this problem area out to!  (-:

If you're going to rely on ordering like this, you must at least use
wmb() to ensure that neither the compiler nor the processor reorders
your stores.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

  reply	other threads:[~2004-10-14 12:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-14 11:26 fishy ->put_inode usage in ntfs Christoph Hellwig
2004-10-14 12:39 ` Anton Altaparmakov
2004-10-14 12:44   ` Matthew Wilcox [this message]
2004-10-14 13:27     ` Anton Altaparmakov
2004-10-14 14:59     ` Anton Altaparmakov
2004-10-14 12:59   ` Christoph Hellwig
2004-10-14 13:26     ` Anton Altaparmakov
2005-02-10 10:47       ` Christoph Hellwig
2005-02-10 14:40         ` Anton Altaparmakov
2005-02-10 14:42           ` Christoph Hellwig
2005-02-10 14:48             ` Anton Altaparmakov
2005-02-10 14:50               ` Anton Altaparmakov
2005-02-10 14:51                 ` Christoph Hellwig
2005-02-10 14:50               ` Christoph Hellwig
2005-02-10 14:59                 ` Anton Altaparmakov
2005-02-13 16:35                   ` Christoph Hellwig
2005-02-14 20:44                     ` Anton Altaparmakov
2005-03-01 23:17                       ` David Woodhouse
2005-03-02  8:43                         ` Anton Altaparmakov
2005-03-02  8:53                           ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041014124400.GL16153@parcelfarce.linux.theplanet.co.uk \
    --to=matthew@wil.cx \
    --cc=aia21@cam.ac.uk \
    --cc=aia21@cantab.net \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-ntfs-dev@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).