From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: fishy ->put_inode usage in ntfs Date: Thu, 14 Oct 2004 13:44:00 +0100 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20041014124400.GL16153@parcelfarce.linux.theplanet.co.uk> References: <20041014112607.GA24508@lst.de> <1097757569.21275.40.camel@imp.csi.cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , aia21@cantab.net, ntfs-dev , linux-fsdevel@vger.kernel.org Return-path: Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:65222 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S263795AbUJNMoC (ORCPT ); Thu, 14 Oct 2004 08:44:02 -0400 To: Anton Altaparmakov Content-Disposition: inline In-Reply-To: <1097757569.21275.40.camel@imp.csi.cam.ac.uk> List-Id: linux-fsdevel.vger.kernel.org On Thu, Oct 14, 2004 at 01:39:30PM +0100, Anton Altaparmakov wrote: > Hm, I can now see that there is a small race window here and this is > simply fixed by doing the setting to NULL of bmp_ino before doing the > iput() of bmp_ino. Thanks for pointing this problem area out to! (-: If you're going to rely on ordering like this, you must at least use wmb() to ensure that neither the compiler nor the processor reorders your stores. -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain