From: Christoph Hellwig <hch@infradead.org>
To: Vladimir Saveliev <vs@namesys.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"reiserfs-dev@namesys.com" <reiserfs-dev@namesys.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: 2.6.9-mm1 (about reiser4 patches)
Date: Sat, 23 Oct 2004 14:08:33 +0100 [thread overview]
Message-ID: <20041023130833.GA31715@infradead.org> (raw)
In-Reply-To: <20041023125423.GA31593@infradead.org>
On Sat, Oct 23, 2004 at 01:54:23PM +0100, Christoph Hellwig wrote:
> So what you want is actually to move the truncate_inode_pages out of
> generic_delete_inode and into ->delete_inode?
Looking at the code another strategt makes more sense:
- move the truncate_inode_pages at the beginning of clear_inode.
All callers but one already do it just before that call, but
the one that doesn't will require a full audit of all ->delete_inode
instances
- make the first half of clear_inode into a helper (__clear_inode or
whatever), and make ->clear_inode responsible for calling it as first
thing for a normal fs or call it in clear_inode if ->clear_inode doesn't
exist. that way we can also move the invalidate_inode_buffers out there
easily later for filesystems that don't use buffer_heads at all.
p.s. please try to keep -fsdevel Cc'ed on the mail related to core changes
parent reply other threads:[~2004-10-23 13:08 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20041023125423.GA31593@infradead.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041023130833.GA31715@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=reiserfs-dev@namesys.com \
--cc=vs@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).