From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: 2.6.9-mm1 (about reiser4 patches) Date: Sat, 23 Oct 2004 14:08:33 +0100 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20041023130833.GA31715@infradead.org> References: <1098524855.1380.19.camel@tribesman.namesys.com> <20041023095747.GA30278@infradead.org> <1098535543.2910.55.camel@tribesman.namesys.com> <20041023125423.GA31593@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , "reiserfs-dev@namesys.com" , linux-fsdevel@vger.kernel.org Return-path: Received: from phoenix.infradead.org ([81.187.226.98]:43275 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S261166AbUJWNIh (ORCPT ); Sat, 23 Oct 2004 09:08:37 -0400 To: Vladimir Saveliev Content-Disposition: inline In-Reply-To: <20041023125423.GA31593@infradead.org> List-Id: linux-fsdevel.vger.kernel.org On Sat, Oct 23, 2004 at 01:54:23PM +0100, Christoph Hellwig wrote: > So what you want is actually to move the truncate_inode_pages out of > generic_delete_inode and into ->delete_inode? Looking at the code another strategt makes more sense: - move the truncate_inode_pages at the beginning of clear_inode. All callers but one already do it just before that call, but the one that doesn't will require a full audit of all ->delete_inode instances - make the first half of clear_inode into a helper (__clear_inode or whatever), and make ->clear_inode responsible for calling it as first thing for a normal fs or call it in clear_inode if ->clear_inode doesn't exist. that way we can also move the invalidate_inode_buffers out there easily later for filesystems that don't use buffer_heads at all. p.s. please try to keep -fsdevel Cc'ed on the mail related to core changes