* Re: 2.6.9-mm1 (about reiser4 patches)
[not found] ` <20041023125423.GA31593@infradead.org>
@ 2004-10-23 13:08 ` Christoph Hellwig
0 siblings, 0 replies; only message in thread
From: Christoph Hellwig @ 2004-10-23 13:08 UTC (permalink / raw)
To: Vladimir Saveliev
Cc: Christoph Hellwig, reiserfs-dev@namesys.com, linux-fsdevel
On Sat, Oct 23, 2004 at 01:54:23PM +0100, Christoph Hellwig wrote:
> So what you want is actually to move the truncate_inode_pages out of
> generic_delete_inode and into ->delete_inode?
Looking at the code another strategt makes more sense:
- move the truncate_inode_pages at the beginning of clear_inode.
All callers but one already do it just before that call, but
the one that doesn't will require a full audit of all ->delete_inode
instances
- make the first half of clear_inode into a helper (__clear_inode or
whatever), and make ->clear_inode responsible for calling it as first
thing for a normal fs or call it in clear_inode if ->clear_inode doesn't
exist. that way we can also move the invalidate_inode_buffers out there
easily later for filesystems that don't use buffer_heads at all.
p.s. please try to keep -fsdevel Cc'ed on the mail related to core changes
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-10-23 13:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1098524855.1380.19.camel@tribesman.namesys.com>
[not found] ` <20041023095747.GA30278@infradead.org>
[not found] ` <1098535543.2910.55.camel@tribesman.namesys.com>
[not found] ` <20041023125423.GA31593@infradead.org>
2004-10-23 13:08 ` 2.6.9-mm1 (about reiser4 patches) Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).