From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 20/28] HOTPLUG: call_usermodehelper callback support Date: Mon, 25 Oct 2004 16:18:42 +0100 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20041025151842.GA1858@infradead.org> References: <10987156903663@sun.com> <10987157204162@sun.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, raven@themaw.net Return-path: Received: from phoenix.infradead.org ([81.187.226.98]:60684 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S261963AbUJYPSn (ORCPT ); Mon, 25 Oct 2004 11:18:43 -0400 To: Mike Waychison Content-Disposition: inline In-Reply-To: <10987157204162@sun.com> List-Id: linux-fsdevel.vger.kernel.org On Mon, Oct 25, 2004 at 10:48:40AM -0400, Mike Waychison wrote: > This patch extends the call_usermodehelper api by adding a callback variant. > The callback is made right when the system is about to call execve into the > new process. This allows for the caller to provide changes to the default > environment right before the exec takes place. Note: the context of the > callback will be _from within another process_. I don't like this at all. First it's the usual fork() + exec() vs spawn() with gazillions of arguments debatte, second this sounds far too complex to do it in kernelspace to me. Why can't you do the enviroment changes from the program beeing executed?