From: Jan Harkes <jaharkes@cs.cmu.edu>
To: janitor@sternwelten.at
Cc: akpm@osdl.org, linux-fsdevel@vger.kernel.org, domen@coderock.org
Subject: Re: [patch 1/1] list_for_each_entry: fs-coda-psdev.c
Date: Sat, 30 Oct 2004 23:22:55 -0400 [thread overview]
Message-ID: <20041031032255.GC317@delft.aura.cs.cmu.edu> (raw)
In-Reply-To: <E1CO1mN-0001US-Eb@sputnik>
On Sun, Oct 31, 2004 at 12:32:59AM +0200, janitor@sternwelten.at wrote:
> Use list_for_each_entry_safe to make code more readable.
I have no problem with this patch, I'm just wondering whether it is
really worth the trouble.
Readability isn't all that bad with the existing 2 lines. Code wise it
is identical, and if this is such a big deal why aren't the other
list_for_each/list_entry macros in the same file corrected as well?
Jan
prev parent reply other threads:[~2004-10-31 3:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-30 22:32 [patch 1/1] list_for_each_entry: fs-coda-psdev.c janitor
2004-10-31 3:22 ` Jan Harkes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041031032255.GC317@delft.aura.cs.cmu.edu \
--to=jaharkes@cs.cmu.edu \
--cc=akpm@osdl.org \
--cc=domen@coderock.org \
--cc=janitor@sternwelten.at \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).