From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Harkes Subject: Re: [patch 1/1] list_for_each_entry: fs-coda-psdev.c Date: Sat, 30 Oct 2004 23:22:55 -0400 Message-ID: <20041031032255.GC317@delft.aura.cs.cmu.edu> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@osdl.org, linux-fsdevel@vger.kernel.org, domen@coderock.org Return-path: Received: from DELFT.AURA.CS.CMU.EDU ([128.2.206.88]:7300 "EHLO delft.aura.cs.cmu.edu") by vger.kernel.org with ESMTP id S261485AbUJaDXF (ORCPT ); Sat, 30 Oct 2004 23:23:05 -0400 To: janitor@sternwelten.at Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sun, Oct 31, 2004 at 12:32:59AM +0200, janitor@sternwelten.at wrote: > Use list_for_each_entry_safe to make code more readable. I have no problem with this patch, I'm just wondering whether it is really worth the trouble. Readability isn't all that bad with the existing 2 lines. Code wise it is identical, and if this is such a big deal why aren't the other list_for_each/list_entry macros in the same file corrected as well? Jan