Re: [PATCH] Fix O_SYNC speedup for generic_file_write_nolock

[Joel Becker <Joel.Becker@oracle.com>]

On Mon, Nov 08, 2004 at 01:05:44PM +0100, Arjan van de Ven wrote:
> On Mon, 2004-11-08 at 17:23 +0530, Suparna Bhattacharya wrote:
> > On Mon, Nov 08, 2004 at 11:04:38AM +0100, Arjan van de Ven wrote:
> > > > +EXPORT_SYMBOL(sync_page_range_nolock);
> > > 
> > > 
> > > why adding this export? nothing appears to be using it (AIO isn't a module after all)
> > > 
> > 
> > This doesn't have anything to do with AIO. Filesystems which implement 
> > the equivalent of generic_file_write_nolock may use sync_page_range_nolock
> > for O_SYNC.
> > 
> > Does that help clarify ?
> 
> not really; none do so far so how about not adding the export until
> someone does use it ?

	OCFS2 uses generic_file_write_nolock(), and as such we might
want to look into this problem and the sync_page_range_nolock() fix.

Joel


-- 

"I always thought the hardest questions were those I could not answer.
 Now I know they are the ones I can never ask."
			- Charlie Watkins

Joel Becker
Senior Member of Technical Staff
Oracle Corporation
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127