From: "Frank Denis \(Jedi/Sector One\)" <lkml@pureftpd.org>
To: Bruce Allan <bwa@us.ibm.com>
Cc: matthew@wil.cx, linux-kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] [resend] VFS locking errors on max offset edge cases
Date: Fri, 24 Dec 2004 02:08:03 +0100 [thread overview]
Message-ID: <20041224010825.GA28608@c9x.org> (raw)
In-Reply-To: <1103842880.4702.87.camel@w-bwa3.beaverton.ibm.com>
On Thu, Dec 23, 2004 at 03:01:20PM -0800, Bruce Allan wrote:
> Patch created against 2.6.10-rc3, tested on ppc64 with both
> _FILE_OFFSET_BITS set to 32 and 64.
> diff -Nurp -X dontdiff linux-2.6.10-rc3-vanilla/fs/compat.c linux-2.6.10-rc3/fs/compat.c
> + if ((cmd == F_GETLK) &&
> + ((f.l_start > COMPAT_OFF_T_MAX) ||
> + ((f.l_start + f.l_len - 1) > COMPAT_OFF_T_MAX))) {
> + ret = -EOVERFLOW;
> + break;
> + }
> + }
One extra },
> + if ((cmd == F_GETLK64) &&
> + ((f.l_start > COMPAT_LOFF_T_MAX) ||
> + ((f.l_start + f.l_len - 1) > COMPAT_LOFF_T_MAX))) {
> + ret = -EOVERFLOW;
> + break;
> + }
> + }
Another extra }.
How could have this patch been tested?
next prev parent reply other threads:[~2004-12-24 1:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-23 23:01 [PATCH] [resend] VFS locking errors on max offset edge cases Bruce Allan
2004-12-24 1:08 ` Frank Denis (Jedi/Sector One) [this message]
2004-12-24 3:26 ` Matthew Wilcox
2004-12-30 21:38 ` Bruce Allan
2005-02-18 23:27 ` Bruce Allan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041224010825.GA28608@c9x.org \
--to=lkml@pureftpd.org \
--cc=bwa@us.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).