From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Subject: Re: [PATCH] fix double iget in romfs_fill_super
Date: Sat, 8 Jan 2005 14:55:36 +0000
Message-ID: <20050108145536.GC26051@parcelfarce.linux.theplanet.co.uk>
References: <20050108144425.GA3561@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: akpm@osdl.org, linux-fsdevel@vger.kernel.org,
	Linus Torvalds <torvalds@osdl.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:46504 "EHLO
	www.linux.org.uk") by vger.kernel.org with ESMTP id S261182AbVAHOzh
	(ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Sat, 8 Jan 2005 09:55:37 -0500
To: Christoph Hellwig <hch@lst.de>
Content-Disposition: inline
In-Reply-To: <20050108144425.GA3561@lst.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

ACK

On Sat, Jan 08, 2005 at 03:44:25PM +0100, Christoph Hellwig wrote:
> --- linux-2.6.10-mm2.orig/fs/romfs/inode.c	2004-12-24 22:35:01.000000000 +0100
> +++ linux-2.6.10-mm2/fs/romfs/inode.c	2005-01-08 15:49:55.238871280 +0100
> @@ -161,8 +161,7 @@ static int romfs_fill_super(struct super
>  	if (!root)
>  		goto out;
>  
> -	s->s_root = d_alloc_root(iget(s, sz));
> -
> +	s->s_root = d_alloc_root(root);
>  	if (!s->s_root)
>  		goto outiput;
>