From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: hch@lst.de, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] factor out common code around ->follow_link invocation
Date: Fri, 14 Jan 2005 00:38:04 +0000 [thread overview]
Message-ID: <20050114003804.GL26051@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20050113163449.61b1be2a.akpm@osdl.org>
On Thu, Jan 13, 2005 at 04:34:49PM -0800, Andrew Morton wrote:
> > > Now there's a fairly insane amount of inlining going on around
> > > do_follow_link() and __do_follow_link(). It makes my fingers itchy.
> > >
> > > ow. __do_follow_link inlines __vfs_follow_link inlines walk_init_root and
> > > __do_follow_link has maybe three callsites.
> >
> > No. These guys are in the middle of mutual recursion. So in this
> > particular case we *do* need inlining.
>
> <head spins> How can you do mutually-recursive code with inline functions
> without generating an infinite amount of code?
"In the middle of" != "entire"
> Wanna spell it out a bit more please?
link_path_walk -> do_follow_link -> __vfs_follow_link -> link_path_walk
link_path_walk() is not inline. The rest of the thing would better be.
prev parent reply other threads:[~2005-01-14 0:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-13 16:53 [PATCH] factor out common code around ->follow_link invocation Christoph Hellwig
2005-01-13 18:35 ` file system writes jenn
2005-01-13 21:31 ` Jan Hudec
2005-01-14 0:11 ` jenn
2005-01-14 0:06 ` [PATCH] factor out common code around ->follow_link invocation Andrew Morton
2005-01-14 0:21 ` Al Viro
2005-01-14 0:34 ` Andrew Morton
2005-01-14 0:38 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050114003804.GL26051@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).