From: Andrew Morton <akpm@osdl.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: jack@suse.cz, adilger@clusterfs.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] Minor ext3 speedup
Date: Sun, 16 Jan 2005 01:03:31 -0800 [thread overview]
Message-ID: <20050116010331.3d9c30ec.akpm@osdl.org> (raw)
In-Reply-To: <20050115170441.GR30982@parcelfarce.linux.theplanet.co.uk>
Matthew Wilcox <matthew@wil.cx> wrote:
>
> On Thu, Jan 13, 2005 at 01:15:06PM +0100, Jan Kara wrote:
> > Attached patch removes unnecessary division and modulo from ext3 code
> > paths. It reduces (according to oprofile) the CPU usage measurably under
> > a dbench load (see description of the patch for the numbers).
>
> I thought I'd apply Jan & Andreas's patch to ext2 too. While doing so,
> I noticed several places where patches had been applied to ext2 and not to
> ext3. One of them was even a bugfix. This patch brings ext2/balloc.c
> and ext3/balloc.c closer together and fixes the bug. It includes the
> aforementioned patch for both ext2 and ext3.
>
> For the curious, the bug occurs when ext3_free_blocks_sb() decides to
> "do_more". *pdquot_freed_blocks was updated each time around the loop,
> so bg_free_blocks_count was getting over-incremented. I fixed it the
> same way it had been fixed in ext2 -- by introducing a group_freed
> variable that is reset each time around the loop.
The patch does boatloads of other things too.
Matthew. You know the routine ;)
prev parent reply other threads:[~2005-01-16 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-13 12:15 [PATCH] Minor ext3 speedup Jan Kara
2005-01-15 17:04 ` Matthew Wilcox
2005-01-16 9:03 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050116010331.3d9c30ec.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=adilger@clusterfs.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).