[PATCH] fat: fix writev(), add aio support

[PATCH] fat: fix writev(), add aio support

[Christoph Hellwig]

This patch fixes vectored write support on fat to do the nessecary
non-standard action done in write() aswell.

Also adds aio support and makes read/write wrappers around the aio
version.


--- 1.28/fs/fat/file.c	2005-01-21 06:02:08 +01:00
+++ edited/fs/fat/file.c	2005-01-25 14:10:05 +01:00
@@ -12,13 +12,28 @@
 #include <linux/smp_lock.h>
 #include <linux/buffer_head.h>
 
-static ssize_t fat_file_write(struct file *filp, const char __user *buf,
-			      size_t count, loff_t *ppos)
+static ssize_t fat_file_aio_write(struct kiocb *iocb, const char __user *buf,
+				  size_t count, loff_t pos)
+{
+	struct inode *inode = iocb->ki_filp->f_dentry->d_inode;
+	int retval;
+
+	retval = generic_file_aio_write(iocb, buf, count, pos);
+	if (retval > 0) {
+		inode->i_mtime = inode->i_ctime = CURRENT_TIME_SEC;
+		MSDOS_I(inode)->i_attrs |= ATTR_ARCH;
+		mark_inode_dirty(inode);
+	}
+	return retval;
+}
+
+static ssize_t fat_file_writev(struct file *filp, const struct iovec *iov,
+			       unsigned long nr_segs, loff_t *ppos)
 {
 	struct inode *inode = filp->f_dentry->d_inode;
 	int retval;
 
-	retval = generic_file_write(filp, buf, count, ppos);
+	retval = generic_file_writev(filp, iov, nr_segs, ppos);
 	if (retval > 0) {
 		inode->i_mtime = inode->i_ctime = CURRENT_TIME_SEC;
 		MSDOS_I(inode)->i_attrs |= ATTR_ARCH;
@@ -29,12 +44,14 @@
 
 struct file_operations fat_file_operations = {
 	.llseek		= generic_file_llseek,
-	.read		= generic_file_read,
-	.write		= fat_file_write,
+	.read		= do_sync_read,
+	.write		= do_sync_write,
+	.readv		= generic_file_readv,
+	.writev		= fat_file_writev,
+	.aio_read	= generic_file_aio_read,
+	.aio_write	= fat_file_aio_write,
 	.mmap		= generic_file_mmap,
 	.fsync		= file_fsync,
-	.readv		= generic_file_readv,
-	.writev		= generic_file_writev,
 	.sendfile	= generic_file_sendfile,
 };
 

Re: [PATCH] fat: fix writev(), add aio support

[OGAWA Hirofumi]

Christoph Hellwig <hch@lst.de> writes:

> This patch fixes vectored write support on fat to do the nessecary
> non-standard action done in write() aswell.
>
> Also adds aio support and makes read/write wrappers around the aio
> version.

The fatfs doesn't have the ->direct_IO(), so the AIO stuff seems to be
not useful for now. However, patch itself looks good.

Thanks, I'll submit.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

Re: [PATCH] fat: fix writev(), add aio support

[Christoph Hellwig]

On Wed, Jan 26, 2005 at 02:38:30AM +0900, OGAWA Hirofumi wrote:
> Christoph Hellwig <hch@lst.de> writes:
> 
> > This patch fixes vectored write support on fat to do the nessecary
> > non-standard action done in write() aswell.
> >
> > Also adds aio support and makes read/write wrappers around the aio
> > version.
> 
> The fatfs doesn't have the ->direct_IO(), so the AIO stuff seems to be
> not useful for now.

I kinda agree.  It's usefull

 a) to make aio actually work with the aio patch that Suparna keeps
 b) make the methods and feature sets uniqueue over all intree filesystems