From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: Advice sought on how to lock multiple pages in ->prepare_write and ->writepage Date: Tue, 1 Feb 2005 01:29:20 +0000 Message-ID: <20050201012920.GA9412@parcelfarce.linux.theplanet.co.uk> References: <20050128050614.GC1799@frodo> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Nathan Scott , Anton Altaparmakov , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-xfs@oss.sgi.com, viro@parcelfarce.linux.theplanet.co.uk Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:49811 "EHLO parcelfarce.linux.theplanet.co.uk") by vger.kernel.org with ESMTP id S261347AbVBAB3a (ORCPT ); Mon, 31 Jan 2005 20:29:30 -0500 To: Bryan Henderson Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Jan 28, 2005 at 02:53:41PM -0800, Bryan Henderson wrote: > >Just putting up my hand to say "yeah, us too" - we could also make > >use of that functionality, so we can grok existing XFS filesystems > >that have blocksizes larger than the page size. > > IBM Storage Tank has block size > page size and has the same problem. This > is one of several ways that Storage Tank isn't generic enough to use > generic_file_write() and generic_file_read(), so it doesn't. That's not a > terrible way to go, by the way. At some point, making the generic > interface complex enough to handle every possible filesystem becomes worse > than every filesystem driver having its own code. That's certainly true; but it might make sense to write a multipage_file_read() and multipage_file_write() that can be shared between the filesystems that do need this complexity. -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain