From: Andrew Morton <akpm@osdl.org>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: mpage writepage question
Date: Thu, 3 Feb 2005 10:52:41 -0800 [thread overview]
Message-ID: <20050203105241.3e249338.akpm@osdl.org> (raw)
In-Reply-To: <1107448638.3503.473.camel@dyn318077bld.beaverton.ibm.com>
Badari Pulavarty <pbadari@us.ibm.com> wrote:
>
> Hi Andrew,
>
> I was wondering why mpage_writepage() is only "static" ?
Good question.
> Is the expectation that, filesystems use
>
> .writepage == block_full_write_page
> .writepages == mpage_writepages
>
> ? I am little confused on why we have 2 different ways to
> do things ? block_full_write_page() seems to be creating
> buffer heads, where as mpage_writepages() can do directly
> bios. Shouldn't they be using mpage_writepage() instead of
> block_full_write_page() ?
I have a feeling that we used to have a single-page writepage function in
fs/mpage.c a long time ago. The current mpage_writepage() is an
internal-only function and isn't suitable and should really be renamed.
But it certainly looks doable.
The new writepage function would need to fall back to
__block_write_full_page() in many situations, but the current code in there
does all that.
prev parent reply other threads:[~2005-02-03 18:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-03 16:37 mpage writepage question Badari Pulavarty
2005-02-03 17:10 ` Sonny Rao
2005-02-03 18:52 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050203105241.3e249338.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).