From: Sonny Rao <sonny@burdell.org>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: linux-fsdevel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: mpage writepage question
Date: Thu, 3 Feb 2005 12:10:05 -0500 [thread overview]
Message-ID: <20050203171005.GA27332@kevlar.burdell.org> (raw)
In-Reply-To: <1107448638.3503.473.camel@dyn318077bld.beaverton.ibm.com>
On Thu, Feb 03, 2005 at 08:37:19AM -0800, Badari Pulavarty wrote:
> Hi Andrew,
>
> I was wondering why mpage_writepage() is only "static" ?
>
> Is the expectation that, filesystems use
>
> .writepage == block_full_write_page
> .writepages == mpage_writepages
>
> ? I am little confused on why we have 2 different ways to
> do things ? block_full_write_page() seems to be creating
> buffer heads, where as mpage_writepages() can do directly
> bios. Shouldn't they be using mpage_writepage() instead of
> block_full_write_page() ?
>
I was wondering the same thing too.
My only guess is that if you keep the buffer_head attached to the
page, then you don't need to call get_block again if you write the
same page back, and I suppose the fs get_block function could be
expensive and/or require I/O.
Sonny
next prev parent reply other threads:[~2005-02-03 17:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-03 16:37 mpage writepage question Badari Pulavarty
2005-02-03 17:10 ` Sonny Rao [this message]
2005-02-03 18:52 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050203171005.GA27332@kevlar.burdell.org \
--to=sonny@burdell.org \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).