From: Sonny Rao <sonny@burdell.org>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: ext3 writepages ?
Date: Thu, 3 Feb 2005 12:24:05 -0500 [thread overview]
Message-ID: <20050203172405.GA27710@kevlar.burdell.org> (raw)
In-Reply-To: <1107449810.3503.479.camel@dyn318077bld.beaverton.ibm.com>
On Thu, Feb 03, 2005 at 08:56:50AM -0800, Badari Pulavarty wrote:
> On Thu, 2005-02-03 at 09:00, Sonny Rao wrote:
>
> >
> > Well it seems to work, here's my (rather ugly) patch.
> > I'm doing some performance comparisons now.
> >
> > Sonny
>
> Interesting.. Why did you create a nobh_prepare_write() ?
> mpage_writepages() can handle pages with buffer heads
> attached.
IIRC, block_prepare_write will attach buffer_heads for you, which I'm
explicitly trying to avoid.
> And also, are you sure you don't need to journal start/stop
> in writepages() ?
Heh, I'm not sure, I don't understand the semantics of those calls
well enough to say with certainty.
My guess is no, because the blocks on disk were already allocated
beforehand. Maybe it could be a problem if there could be a truncate
in progress elsewhere, but I don't think so since the inode is
locked.
Sonny
next prev parent reply other threads:[~2005-02-03 17:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-02 15:32 ext3 writepages ? Badari Pulavarty
2005-02-02 20:19 ` Sonny Rao
2005-02-03 15:51 ` Badari Pulavarty
2005-02-03 17:00 ` Sonny Rao
2005-02-03 16:56 ` Badari Pulavarty
2005-02-03 17:24 ` Sonny Rao [this message]
2005-02-03 20:50 ` Sonny Rao
2005-02-08 1:33 ` Andreas Dilger
2005-02-08 5:38 ` Sonny Rao
2005-02-09 21:11 ` Sonny Rao
2005-02-09 22:29 ` Badari Pulavarty
2005-02-10 2:05 ` Bryan Henderson
2005-02-10 2:45 ` Sonny Rao
2005-02-10 17:51 ` Bryan Henderson
2005-02-10 19:02 ` Sonny Rao
2005-02-10 16:02 ` Badari Pulavarty
2005-02-10 18:00 ` Bryan Henderson
2005-02-10 18:32 ` Badari Pulavarty
2005-02-10 20:30 ` Bryan Henderson
2005-02-10 20:25 ` Sonny Rao
2005-02-11 0:20 ` Bryan Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050203172405.GA27710@kevlar.burdell.org \
--to=sonny@burdell.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).