From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sonny Rao Subject: Re: ext3 writepages ? Date: Thu, 3 Feb 2005 12:24:05 -0500 Message-ID: <20050203172405.GA27710@kevlar.burdell.org> References: <1107358324.3503.424.camel@dyn318077bld.beaverton.ibm.com> <20050202201953.GA2728@kevlar.burdell.org> <1107445897.3503.465.camel@dyn318077bld.beaverton.ibm.com> <20050203170004.GA27239@kevlar.burdell.org> <1107449810.3503.479.camel@dyn318077bld.beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org Received: from dsl027-162-124.atl1.dsl.speakeasy.net ([216.27.162.124]:13259 "EHLO kevlar.burdell.org") by vger.kernel.org with ESMTP id S263373AbVBCRgp (ORCPT ); Thu, 3 Feb 2005 12:36:45 -0500 To: Badari Pulavarty Content-Disposition: inline In-Reply-To: <1107449810.3503.479.camel@dyn318077bld.beaverton.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Feb 03, 2005 at 08:56:50AM -0800, Badari Pulavarty wrote: > On Thu, 2005-02-03 at 09:00, Sonny Rao wrote: > > > > > Well it seems to work, here's my (rather ugly) patch. > > I'm doing some performance comparisons now. > > > > Sonny > > Interesting.. Why did you create a nobh_prepare_write() ? > mpage_writepages() can handle pages with buffer heads > attached. IIRC, block_prepare_write will attach buffer_heads for you, which I'm explicitly trying to avoid. > And also, are you sure you don't need to journal start/stop > in writepages() ? Heh, I'm not sure, I don't understand the semantics of those calls well enough to say with certainty. My guess is no, because the blocks on disk were already allocated beforehand. Maybe it could be a problem if there could be a truncate in progress elsewhere, but I don't think so since the inode is locked. Sonny