From: Christoph Hellwig <hch@lst.de>
To: Anton Altaparmakov <aia21@cam.ac.uk>
Cc: Christoph Hellwig <hch@lst.de>,
ntfs-dev <linux-ntfs-dev@lists.sourceforge.net>,
fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: fishy ->put_inode usage in ntfs
Date: Thu, 10 Feb 2005 15:51:06 +0100 [thread overview]
Message-ID: <20050210145106.GB7399@lst.de> (raw)
In-Reply-To: <1108047002.12000.19.camel@imp.csi.cam.ac.uk>
On Thu, Feb 10, 2005 at 02:50:02PM +0000, Anton Altaparmakov wrote:
> > If the igrab() were not done, it would be possible for clear_inode to be
> > called on the 'parent' inode whilst at the same time one or more attr
> > inodes (belonging to this 'parent') are in use and Bad Things(TM) would
> > happen...
>
> The igrab() effectively guarantees that iput() is called on all attr
> inodes before clear_inode on the 'parent' can be invoked.
Yes, but why exactly is this important. It looks like you're absuing
the refcount on the 'parent' inode for some shared data?
next prev parent reply other threads:[~2005-02-10 14:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-14 11:26 fishy ->put_inode usage in ntfs Christoph Hellwig
2004-10-14 12:39 ` Anton Altaparmakov
2004-10-14 12:44 ` Matthew Wilcox
2004-10-14 13:27 ` Anton Altaparmakov
2004-10-14 14:59 ` Anton Altaparmakov
2004-10-14 12:59 ` Christoph Hellwig
2004-10-14 13:26 ` Anton Altaparmakov
2005-02-10 10:47 ` Christoph Hellwig
2005-02-10 14:40 ` Anton Altaparmakov
2005-02-10 14:42 ` Christoph Hellwig
2005-02-10 14:48 ` Anton Altaparmakov
2005-02-10 14:50 ` Anton Altaparmakov
2005-02-10 14:51 ` Christoph Hellwig [this message]
2005-02-10 14:50 ` Christoph Hellwig
2005-02-10 14:59 ` Anton Altaparmakov
2005-02-13 16:35 ` Christoph Hellwig
2005-02-14 20:44 ` Anton Altaparmakov
2005-03-01 23:17 ` David Woodhouse
2005-03-02 8:43 ` Anton Altaparmakov
2005-03-02 8:53 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050210145106.GB7399@lst.de \
--to=hch@lst.de \
--cc=aia21@cam.ac.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).