From: Andrew Morton <akpm@osdl.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] block new writers on frozen filesystems
Date: Thu, 10 Feb 2005 15:14:27 -0800 [thread overview]
Message-ID: <20050210151427.3fc65d56.akpm@osdl.org> (raw)
In-Reply-To: <20050210161331.GA9001@lst.de>
Christoph Hellwig <hch@lst.de> wrote:
>
> When the lockfs patches went in an important bit got lost, the call in
> generic_file_write to put newly incoming writers to sleep when a
> filesystem is frozen. Nathan added back the call in the now separate
> XFS write patch, and the patch for the generic code is below:
>
>
> Index: mm/filemap.c
> ===================================================================
> RCS file: /cvs/linux-2.6-xfs/mm/filemap.c,v
> retrieving revision 1.14
> diff -u -p -r1.14 filemap.c
> --- mm/filemap.c 5 Jan 2005 14:17:31 -0000 1.14
> +++ mm/filemap.c 4 Feb 2005 21:35:53 -0000
> @@ -2046,6 +2046,8 @@ __generic_file_aio_write_nolock(struct k
> count = ocount;
> pos = *ppos;
>
> + vfs_check_frozen(inode->i_sb, SB_FREEZE_WRITE);
hm, I didn't pay much attention to this stuff. Shouldn't the direct-io
code be waiting as well? Are all paths which can write to the bdev supposed
to be blocked? kjournald?
next prev parent reply other threads:[~2005-02-10 23:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-10 16:13 [PATCH] block new writers on frozen filesystems Christoph Hellwig
2005-02-10 23:14 ` Andrew Morton [this message]
2005-02-13 14:20 ` Christoph Hellwig
2005-02-13 15:05 ` Anton Altaparmakov
2005-02-13 15:24 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050210151427.3fc65d56.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).