From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] block new writers on frozen filesystems
Date: Sun, 13 Feb 2005 15:20:27 +0100
Message-ID: <20050213142027.GA1733@lst.de>
References: <20050210161331.GA9001@lst.de> <20050210151427.3fc65d56.akpm@osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org
Received: from verein.lst.de ([213.95.11.210]:33981 "EHLO mail.lst.de")
	by vger.kernel.org with ESMTP id S261275AbVBMOUe (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sun, 13 Feb 2005 09:20:34 -0500
To: Andrew Morton <akpm@osdl.org>
Content-Disposition: inline
In-Reply-To: <20050210151427.3fc65d56.akpm@osdl.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

> > +	vfs_check_frozen(inode->i_sb, SB_FREEZE_WRITE);
> 
> hm, I didn't pay much attention to this stuff.  Shouldn't the direct-io
> code be waiting as well?  Are all paths which can write to the bdev supposed
> to be blocked?  kjournald?

This should block new data writers.  New metadata writes need to be
blocked in the individual filesystem, and only when the state is set
to SB_FREEZE_TRANS (a few steps later in freeze_bdev).

Currently only XFS deals with that part.