From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: Bufferheads & page-cache reference Date: Tue, 15 Feb 2005 09:54:43 -0800 Message-ID: <20050215095443.3e646401.akpm@osdl.org> References: <1108409415.20053.1278.camel@dyn318077bld.beaverton.ibm.com> <20050214134058.1402cfed.akpm@osdl.org> <1108430825.20053.1363.camel@dyn318077bld.beaverton.ibm.com> <20050214190556.07c4a0c9.akpm@osdl.org> <1108485967.20053.1438.camel@dyn318077bld.beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, ext2-devel@lists.sourceforge.net Received: from fire.osdl.org ([65.172.181.4]:7878 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S261642AbVBORy6 (ORCPT ); Tue, 15 Feb 2005 12:54:58 -0500 To: Badari Pulavarty In-Reply-To: <1108485967.20053.1438.camel@dyn318077bld.beaverton.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Badari Pulavarty wrote: > > Yep. nobh_prepare_write() doesn't add any bufferheads. But > we call block_write_full_page() even for "nobh" case, which > does create bufferheads, attaches to the page and operates > on them.. hmm, yeah, OK, we'll attach bh's in that case. It's a rare case though - when a dirty page falls off the end of the LRU. There's no particular reason why we cannot have a real mpage_writepage() which doesn't use bh's and employ that. I coulda sworn we used to have one.