From mboxrd@z Thu Jan 1 00:00:00 1970 From: domen@coderock.org Subject: [patch 1/7] list_for_each_entry: fs-namespace.c Date: Sun, 06 Mar 2005 11:37:30 +0100 Message-ID: <20050306103731.B895E1F208@trashy.coderock.org> Cc: linux-fsdevel@vger.kernel.org, domen@coderock.org, janitor@sternwelten.at Received: from coderock.org ([193.77.147.115]:60585 "EHLO trashy.coderock.org") by vger.kernel.org with ESMTP id S261374AbVCFKhi (ORCPT ); Sun, 6 Mar 2005 05:37:38 -0500 To: viro@parcelfarce.linux.theplanet.co.uk Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Make code more readable with list_for_each_entry. Compile tested. Signed-off-by: Domen Puncer Signed-off-by: Maximilian Attems Signed-off-by: Domen Puncer --- kj-domen/fs/namespace.c | 4 +--- 1 files changed, 1 insertion(+), 3 deletions(-) diff -puN fs/namespace.c~list-for-each-entry-fs_namespace fs/namespace.c --- kj/fs/namespace.c~list-for-each-entry-fs_namespace 2005-03-05 16:09:03.000000000 +0100 +++ kj-domen/fs/namespace.c 2005-03-05 16:09:03.000000000 +0100 @@ -536,7 +536,6 @@ lives_below_in_same_fs(struct dentry *d, static struct vfsmount *copy_tree(struct vfsmount *mnt, struct dentry *dentry) { struct vfsmount *res, *p, *q, *r, *s; - struct list_head *h; struct nameidata nd; res = q = clone_mnt(mnt, dentry); @@ -545,8 +544,7 @@ static struct vfsmount *copy_tree(struct q->mnt_mountpoint = mnt->mnt_mountpoint; p = mnt; - for (h = mnt->mnt_mounts.next; h != &mnt->mnt_mounts; h = h->next) { - r = list_entry(h, struct vfsmount, mnt_child); + list_for_each_entry(r, &mnt->mnt_mounts, mnt_child) { if (!lives_below_in_same_fs(r->mnt_mountpoint, dentry)) continue; _