From mboxrd@z Thu Jan 1 00:00:00 1970 From: domen@coderock.org Subject: [patch 5/7] fs/clntproc: replace schedule_timeout() with msleep_interruptible() Date: Sun, 06 Mar 2005 11:37:44 +0100 Message-ID: <20050306103745.14B7A1F23B@trashy.coderock.org> Cc: linux-fsdevel@vger.kernel.org, domen@coderock.org, nacc@us.ibm.com Received: from coderock.org ([193.77.147.115]:938 "EHLO trashy.coderock.org") by vger.kernel.org with ESMTP id S261377AbVCFKh6 (ORCPT ); Sun, 6 Mar 2005 05:37:58 -0500 To: viro@parcelfarce.linux.theplanet.co.uk Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Use msleep_interruptible() instead of schedule_timeout(). The existing code is not incorrect, but msleep_interruptible() offers two advantages: 1) consistency across the kernel and 2) human-sensible time units (msecs). Signed-off-by: Nishanth Aravamudan Signed-off-by: Domen Puncer --- kj-domen/fs/lockd/clntproc.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN fs/lockd/clntproc.c~msleep_interruptible-fs_lockd_clntproc fs/lockd/clntproc.c --- kj/fs/lockd/clntproc.c~msleep_interruptible-fs_lockd_clntproc 2005-03-05 16:11:04.000000000 +0100 +++ kj-domen/fs/lockd/clntproc.c 2005-03-05 16:11:04.000000000 +0100 @@ -14,6 +14,7 @@ #include #include #include +#include #include #include #include @@ -298,8 +299,7 @@ nlmclnt_alloc_call(void) return call; } printk("nlmclnt_alloc_call: failed, waiting for memory\n"); - current->state = TASK_INTERRUPTIBLE; - schedule_timeout(5*HZ); + msleep_interruptible(5000); } return NULL; } _