linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: domen@coderock.org
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: linux-fsdevel@vger.kernel.org, domen@coderock.org, nacc@us.ibm.com
Subject: [patch 7/7] fs/clntlock: remove sleep_on*() usage
Date: Sun, 06 Mar 2005 11:37:52 +0100	[thread overview]
Message-ID: <20050306103752.BF6FF1F208@trashy.coderock.org> (raw)



Directly use wait-queues instead of the deprecated
sleep_on_timeout(). Since the sleep in this function is unconditional,
wait_event_timeout() does not appear to be appropriate. Patch is
compile-tested.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Domen Puncer <domen@coderock.org>
---


 kj-domen/fs/lockd/clntlock.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletion(-)

diff -puN fs/lockd/clntlock.c~sleep_on-fs_lockd_clntlock fs/lockd/clntlock.c
--- kj/fs/lockd/clntlock.c~sleep_on-fs_lockd_clntlock	2005-03-05 16:13:13.000000000 +0100
+++ kj-domen/fs/lockd/clntlock.c	2005-03-05 16:13:13.000000000 +0100
@@ -14,6 +14,7 @@
 #include <linux/sunrpc/svc.h>
 #include <linux/lockd/lockd.h>
 #include <linux/smp_lock.h>
+#include <linux/wait.h>
 
 #define NLMDBG_FACILITY		NLMDBG_CLIENT
 
@@ -47,6 +48,7 @@ static struct nlm_wait *	nlm_blocked;
 int
 nlmclnt_block(struct nlm_host *host, struct file_lock *fl, u32 *statp)
 {
+	DEFINE_WAIT(wait);
 	struct nlm_wait	block, **head;
 	int		err;
 	u32		pstate;
@@ -69,7 +71,9 @@ nlmclnt_block(struct nlm_host *host, str
 	 * a 1 minute timeout would do. See the comment before
 	 * nlmclnt_lock for an explanation.
 	 */
-	sleep_on_timeout(&block.b_wait, 30*HZ);
+	prepare_to_wait(&block.b_wait, &wait, TASK_UNINTERRUPTIBLE);
+	schedule_timeout(30*HZ);
+	finish_wait(&block.b_wait, &wait);
 
 	for (head = &nlm_blocked; *head; head = &(*head)->b_next) {
 		if (*head == &block) {
_

                 reply	other threads:[~2005-03-06 10:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050306103752.BF6FF1F208@trashy.coderock.org \
    --to=domen@coderock.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=nacc@us.ibm.com \
    --cc=viro@parcelfarce.linux.theplanet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).