From: Werner Almesberger <werner@almesberger.net>
To: Alex Tomas <alex@clusterfs.com>
Cc: Suparna Bhattacharya <suparna@in.ibm.com>,
Mingming Cao <cmm@us.ibm.com>,
Badari Pulavarty <pbadari@us.ibm.com>,
ext2-devel <ext2-devel@lists.sourceforge.net>,
linux-fsdevel@vger.kernel.org,
abiss-general@lists.sourceforge.net
Subject: Re: Reviewing ext3 improvement patches (delalloc, mballoc, extents)
Date: Mon, 14 Mar 2005 21:28:52 -0300 [thread overview]
Message-ID: <20050314212852.O12802@almesberger.net> (raw)
In-Reply-To: <m364zuxi9z.fsf@bzzz.home.net>; from alex@clusterfs.com on Mon, Mar 14, 2005 at 08:13:28PM +0300
Alex Tomas wrote:
> you can drop PG_locked right as you set PG_writeback, I think
Hmm, not sure. mpage_writepage never calls writepage with PG_writeback,
only with PG_locked. Also, mpage_writepage calls get_block with
PG_locked, so the allocation, which may take a while, holds the lock.
This situation is admittedly a bit annoying: on the one hand, "sync"
should write all dirty data. On the other hand, if a random user
typing "sync" can break performance guarantees, these guarantees
aren't very valuable.
- Werner
--
_________________________________________________________________________
/ Werner Almesberger, Buenos Aires, Argentina werner@almesberger.net /
/_http://www.almesberger.net/____________________________________________/
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
next prev parent reply other threads:[~2005-03-15 0:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-03 8:33 Reviewing ext3 improvement patches (delalloc, mballoc, extents) Suparna Bhattacharya
2005-03-03 9:40 ` Andreas Dilger
2005-03-03 22:10 ` Theodore Ts'o
2005-03-03 22:30 ` Alex Tomas
2005-03-04 11:13 ` Suparna Bhattacharya
2005-03-04 12:29 ` Alex Tomas
2005-03-04 18:25 ` [Ext2-devel] " Andreas Dilger
2005-03-04 1:12 ` [Ext2-devel] " Badari Pulavarty
2005-03-04 1:46 ` Mingming Cao
2005-03-04 3:26 ` Suparna Bhattacharya
2005-03-14 8:36 ` Werner Almesberger
2005-03-14 9:04 ` Suparna Bhattacharya
2005-03-14 15:02 ` Werner Almesberger
2005-03-14 15:43 ` Alex Tomas
2005-03-14 16:37 ` [Ext2-devel] " Werner Almesberger
2005-03-14 17:13 ` Alex Tomas
2005-03-15 0:28 ` Werner Almesberger [this message]
2005-03-14 22:23 ` Bryan Henderson
2005-03-15 0:42 ` Werner Almesberger
2005-03-15 21:59 ` Bryan Henderson
2005-03-04 11:30 ` [Ext2-devel] " Alex Tomas
2005-03-04 15:02 ` Alex Tomas
2005-03-13 14:41 ` Delayed alloc for ordered-mode Suparna Bhattacharya
2005-03-13 19:32 ` Badari Pulavarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050314212852.O12802@almesberger.net \
--to=werner@almesberger.net \
--cc=abiss-general@lists.sourceforge.net \
--cc=alex@clusterfs.com \
--cc=cmm@us.ibm.com \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
--cc=suparna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).