[RFC] set MS_NOATIME on FAT ?

[Werner Almesberger <werner@almesberger.net>]

Hi,

as far as I can tell, none of FAT or its offsprings use atime, so
perhaps fs/fat/inode.c should just set MS_NOATIME, so that we don't
get unnecessary "inode" writes ? (They hurt if you want to reduce
worst-case latency in the write path.)

Here's a patch for 2.6.11 (with some offset, because I pulled it
from a larger patch).

Does this look good ?

Thanks,
- Werner

---------------------------------- cut here -----------------------------------

Signed-off-by: Werner Almesberger <werner@almesberger.net>

--- linux-2.6.11-orig/fs/fat/inode.c	Wed Mar  2 04:38:08 2005
+++ linux-2.6.11/fs/fat/inode.c	Thu Mar  3 01:35:57 2005
@@ -413,7 +483,7 @@ static void __exit fat_destroy_inodecach
 
 static int fat_remount(struct super_block *sb, int *flags, char *data)
 {
-	*flags |= MS_NODIRATIME;
+	*flags |= MS_NODIRATIME | MS_NOATIME;
 	return 0;
 }
 
@@ -1058,7 +1128,7 @@ int fat_fill_super(struct super_block *s
 	sb->s_fs_info = sbi;
 	memset(sbi, 0, sizeof(struct msdos_sb_info));
 
-	sb->s_flags |= MS_NODIRATIME;
+	sb->s_flags |= MS_NODIRATIME | MS_NOATIME;
 	sb->s_magic = MSDOS_SUPER_MAGIC;
 	sb->s_op = &fat_sops;
 	sb->s_export_op = &fat_export_ops;

-- 
  _________________________________________________________________________
 / Werner Almesberger, Buenos Aires, Argentina     werner@almesberger.net /
/_http://www.almesberger.net/____________________________________________/