From: Andrew Morton <akpm@osdl.org>
To: raven@themaw.net
Cc: michael@kmaclub.com, linux-fsdevel@vger.kernel.org,
jmoyer@redhat.com, autofs@linux.kernel.org
Subject: Re: [PATCH 2/3] autofs4 - expiring filesystem from under process
Date: Mon, 11 Apr 2005 00:01:04 -0700 [thread overview]
Message-ID: <20050411000104.430e26fb.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.62.0504102048370.5212@donald.themaw.net>
raven@themaw.net wrote:
>
> static inline int autofs4_ispending(struct dentry *dentry)
> {
> struct autofs_info *inf = autofs4_dentry_ino(dentry);
> + int pending;
>
> - return (dentry->d_flags & DCACHE_AUTOFS_PENDING) ||
> - (inf != NULL && inf->flags & AUTOFS_INF_EXPIRING);
> + if (dentry->d_flags & DCACHE_AUTOFS_PENDING)
> + return 1;
> +
> + if (inf) {
> + spin_lock(&inf->sbi->fs_lock);
> + pending = inf->flags & AUTOFS_INF_EXPIRING;
> + spin_unlock(&inf->sbi->fs_lock);
> + }
> +
> + return pending;
This can obviously return an uninitialised variable.
Were these patches very well tested?
next prev parent reply other threads:[~2005-04-11 7:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-10 12:50 [PATCH 2/3] autofs4 - expiring filesystem from under process raven
2005-04-10 23:15 ` Andrew Morton
2005-04-11 2:44 ` raven
2005-04-11 7:01 ` Andrew Morton [this message]
2005-04-11 8:52 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050411000104.430e26fb.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=autofs@linux.kernel.org \
--cc=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=michael@kmaclub.com \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox