linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Harkes <jaharkes@cs.cmu.edu>
To: "Artem B. Bityuckiy" <dedekind@infradead.org>
Cc: linux-kernel@vger.kernel.org,
	David Woodhouse <dwmw2@infradead.org>,
	viro@math.psu.edu, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] VFS bugfix: two read_inode() calles without clear_inode() call between
Date: Wed, 27 Apr 2005 09:42:33 -0400	[thread overview]
Message-ID: <20050427134233.GB9454@delft.aura.cs.cmu.edu> (raw)
In-Reply-To: <1114607741.12617.4.camel@sauron.oktetlabs.ru>

On Wed, Apr 27, 2005 at 05:15:41PM +0400, Artem B. Bityuckiy wrote:
> Dear VFS developers,
> 
> is it possible to review/comment/apply the patch which fixes a severe
> VFS bug which screws up JFFS2? 
> 
> (the third attempt).

I think this is a problem that hit Coda at some point. We used to have a
linked list that linked all the inodes together. However not long after
the RCU changes, I noticed that this linked list occasionally got
corrupted. I didn't want to dig too deep into all the dcache related
changes where I thought the problem came from, nobody else seemed to be
complaining and the linked list wasn't really necessary so I worked
around the problem by removing the linked list strucure.

But I think you found the actual cause and this patch looks good to me,
it probably should get merged.

Jan

  reply	other threads:[~2005-04-27 13:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-27 13:15 [PATCH] VFS bugfix: two read_inode() calles without clear_inode() call between Artem B. Bityuckiy
2005-04-27 13:42 ` Jan Harkes [this message]
2005-04-27 14:22 ` Miklos Szeredi
2005-04-27 15:57 ` Miklos Szeredi
2005-04-27 16:19   ` Artem B. Bityuckiy
     [not found]     ` <E1DQqZu-0002Rf-00@dorka.pomaz.szeredi.hu>
2005-04-28  7:32       ` Artem B. Bityuckiy
2005-04-28  7:34         ` Andrew Morton
2005-05-04 12:17           ` Artem B. Bityuckiy
2005-05-04 20:04             ` Andrew Morton
2005-05-04 21:35               ` David Woodhouse
2005-05-04 21:58                 ` Andrew Morton
2005-05-05  9:10                   ` David Woodhouse
2005-05-05 16:18                     ` Miklos Szeredi
2005-05-06 11:08                       ` David Woodhouse
2005-06-13 14:45               ` Synchronous FAT Artem B. Bityuckiy
2005-06-14  1:06                 ` Coywolf Qi Hunt
2005-06-14 12:16                   ` Artem B. Bityuckiy
2005-06-15  1:19                     ` Coywolf Qi Hunt
2005-04-28  7:41         ` [PATCH] VFS bugfix: two read_inode() calles without clear_inode() call between Miklos Szeredi
2005-04-28  7:47           ` Artem B. Bityuckiy
  -- strict thread matches above, loose matches on Subject: below --
2005-04-19 12:38 Artem B. Bityuckiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050427134233.GB9454@delft.aura.cs.cmu.edu \
    --to=jaharkes@cs.cmu.edu \
    --cc=dedekind@infradead.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).