From: Christoph Hellwig <hch@infradead.org>
To: Carsten Otte <cotte@freenet.de>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
schwidefsky@de.ibm.com, akpm@osdl.org
Subject: Re: [RFC/PATCH 2/5] mm/fs: execute in place (V2)
Date: Wed, 18 May 2005 16:00:53 +0100 [thread overview]
Message-ID: <20050518150053.GA24389@infradead.org> (raw)
In-Reply-To: <428B57AA.2030006@freenet.de>
On Wed, May 18, 2005 at 04:56:42PM +0200, Carsten Otte wrote:
> I do plainly agree that this would make the code more readable here.
> But it has a significant downside:
> Once you have a different set of file operations for either case, you
> also need to have a different file_operations struct in each individual
> filesystem using this. Also, this moves the check "do we have xip today?"
> from here to the filesystem that needs to decide which file operations
> struct to use.
> Looking forward, there may be multiple filesystems using this which
> leads to duplicating the need for this check.
I don't think that's much of a problem. The filesystem has a new file_operations
instance and decided at read_inode time which one to use. You already have different
address_space operations and a different truncate anyway.
next prev parent reply other threads:[~2005-05-18 15:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1116422644.2202.1.camel@cotte.boeblingen.de.ibm.com>
2005-05-18 13:53 ` [RFC/PATCH 1/5] bdev: execute in place (V2) Carsten Otte
2005-05-18 14:27 ` Christoph Hellwig
2005-05-18 15:36 ` Carsten Otte
2005-05-18 15:37 ` Christoph Hellwig
2005-05-18 13:53 ` [RFC/PATCH 2/5] mm/fs: " Carsten Otte
2005-05-18 14:27 ` Christoph Hellwig
2005-05-18 14:56 ` Carsten Otte
2005-05-18 15:00 ` Christoph Hellwig [this message]
2005-05-18 15:31 ` Carsten Otte
2005-05-18 15:36 ` Christoph Hellwig
2005-05-18 15:50 ` Carsten Otte
2005-05-18 15:53 ` Christoph Hellwig
2005-05-18 13:53 ` [RFC/PATCH 3/5] ext2: " Carsten Otte
2005-05-18 13:53 ` [RFC/PATCH 4/5] loop: " Carsten Otte
2005-05-18 14:28 ` Christoph Hellwig
2005-05-18 14:38 ` Carsten Otte
2005-05-18 13:54 ` [RFC/PATCH 5/5] madvice/fadvice: " Carsten Otte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050518150053.GA24389@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=cotte@freenet.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).