From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [RFC/PATCH 2/5] mm/fs: execute in place (V2) Date: Wed, 18 May 2005 16:36:50 +0100 Message-ID: <20050518153650.GA25322@infradead.org> References: <1116422644.2202.1.camel@cotte.boeblingen.de.ibm.com> <1116424413.2202.17.camel@cotte.boeblingen.de.ibm.com> <20050518142707.GA23162@infradead.org> <428B57AA.2030006@freenet.de> <20050518150053.GA24389@infradead.org> <428B5FC1.3090704@freenet.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, schwidefsky@de.ibm.com, akpm@osdl.org Return-path: To: Carsten Otte Content-Disposition: inline In-Reply-To: <428B5FC1.3090704@freenet.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, May 18, 2005 at 05:31:13PM +0200, Carsten Otte wrote: > - generic_file_read => xip_file_read no need to have that one if you implement aio_read -> use do_sync_read > - generic_file_aio_read => xip_file_aio_read > - __generic_file_aio_read => __xip_file_aio_read readv and aio_read are just wrappers around this one. > - generic_file_sendfile => xip_file_sendfile pretty trivial > - generic file_readv => xip_file_readv > - generic_file_write => xip_file_write just use do_sync_write > - generic_file_aio_write_nolock => xip_file_write_nolock > - __generic_file_write_nolock => __xip_file_write_nolock > - generic_file_write_nolock => xip_file_write_nolock > - generic_file_aio_write => xip_file_aio_write you don't need all these. Just writev and aio_write as wrappers around a common one > - generic_file_mmap => xip_file_mmap this one doesn't share code anyway > - generic_file_readonly_mmap => xip_file_readonly_mmap unless you want to implement a readonly filesystem with xip support you don't need this one.