From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [RFC/PATCH 1/5] bdev: execute in place (V2) Date: Wed, 18 May 2005 16:37:39 +0100 Message-ID: <20050518153739.GA25420@infradead.org> References: <1116422644.2202.1.camel@cotte.boeblingen.de.ibm.com> <1116424403.2202.16.camel@cotte.boeblingen.de.ibm.com> <20050518142739.GB23162@infradead.org> <428B6111.3000802@freenet.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, schwidefsky@de.ibm.com, akpm@osdl.org Return-path: To: Carsten Otte Content-Disposition: inline In-Reply-To: <428B6111.3000802@freenet.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, May 18, 2005 at 05:36:49PM +0200, Carsten Otte wrote: > Christoph Hellwig wrote: > > >>+ int (*direct_access) (struct inode *, sector_t, unsigned long *); > >> > >> > > > >this should have a block_device * first argument. > > > > > While I agree that (block_device *) would be a good thing to address > the target block device, the inode * is consistent with other > operations in this vector: open, release, & ioctl use the same scheme. That's going to change real soon. > The reason for inode * here is that the caller has no easy way to get > to the block_device *. How would the filesystem do that? sb->s_bdev