From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [RFC/PATCH 2/5] mm/fs: execute in place (V2) Date: Wed, 18 May 2005 16:53:15 +0100 Message-ID: <20050518155315.GA25771@infradead.org> References: <1116422644.2202.1.camel@cotte.boeblingen.de.ibm.com> <1116424413.2202.17.camel@cotte.boeblingen.de.ibm.com> <20050518142707.GA23162@infradead.org> <428B57AA.2030006@freenet.de> <20050518150053.GA24389@infradead.org> <428B5FC1.3090704@freenet.de> <20050518153650.GA25322@infradead.org> <428B6463.3000604@freenet.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, schwidefsky@de.ibm.com, akpm@osdl.org Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:1512 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S262286AbVERPxT (ORCPT ); Wed, 18 May 2005 11:53:19 -0400 To: Carsten Otte Content-Disposition: inline In-Reply-To: <428B6463.3000604@freenet.de> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, May 18, 2005 at 05:50:59PM +0200, Carsten Otte wrote: > I agree that sync/async is not too much of a difference when you do a memcpy > behind, so you can just have wrappers. They already are wrappers in filemap.c In fact one of my planned projects is to kill all that silly duplication and have aio_readv/aio_writev entry points for filesystems and read/write for drivers and nothing else. That would cleanup the mess extremly. > I am still not convinced that it > will stay > reasonably small with all that duplicated stuff, but since it's easy to > do I just > gonna give it a try to see how it'll look alike. Bet the patch size will > double. I think that's okay. XIP is a total minority feature, and while we should avoid duolication where possible not making filemap.c even more messy is by far preferable.