Re: [Ocfs2-devel] Re: [RFC] [PATCH] OCFS2

[Manish Singh <manish.singh@oracle.com>]

On Thu, May 19, 2005 at 01:40:22AM +0200, Adrian Bunk wrote:
> On Wed, May 18, 2005 at 03:33:03PM -0700, Mark Fasheh wrote:
> >...
> > A full patch can be downloaded from:
> > http://oss.oracle.com/projects/ocfs2/dist/files/patches/2.6.12-rc4/complete/ocfs2-configfs-all.patch
> >...
> 
> Some comments on this patch:
> - there's no reason to make JBD user-visible

Sure, the only reason I made it visible was because of the comment in
there:

# CONFIG_JBD could be its own option (even modular), but until there are
# other users than ext3, we will simply make it be the same as CONFIG_EXT3_FS

I don't really have a preference either way.

> - is there any reason why CONFIGFS_FS is user-visible?

It's a generic mechanism for userspace driven configuration of kernel
functionality. There's nothing specific to OCFS2 about it. Other kernel
subsystems/projects could use it too, for their own configuration
mechanisms. More details are in configfs.txt, which is included in the
above patch. Note the example used in the documentation text is an NBD
driver.

> - some global code might become static:
>   run "make namespacecheck" after compiling the kernel and check
>   the configfs and ocfs2 parts of the output

Yeah, there's some stuff that that scripts catches. Thanks.

-Manish