From: Daniel Phillips <phillips@istop.com>
To: Mark Fasheh <mark.fasheh@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
ocfs2-devel@oss.oracle.com, torvalds@osdl.org, akpm@osdl.org,
wim.coekaerts@oracle.com, lmb@suse.de
Subject: Re: [RFC] [PATCH] OCFS2
Date: Thu, 19 May 2005 02:30:23 -0400 [thread overview]
Message-ID: <200505190230.23624.phillips@istop.com> (raw)
In-Reply-To: <20050518223303.GE1340@ca-server1.us.oracle.com>
On Wednesday 18 May 2005 18:33, Mark Fasheh wrote:
> http://oss.oracle.com/projects/ocfs2/dist/files/patches/2.6.12-rc4/broken-o
>ut/06_dlm.patch A distributed lock manager built with the cluster file
> system use case in mind. The OCFS2 dlm exposes a VMS style API, though
> things have been simplified internally. The only lock levels implemented
> currently are NLMODE, PRMODE and EXMODE.
+ if (recovery &&
+ (!dlm_is_recovery_lock(name, strlen(name)) || convert) ) {
+ goto error;
+ }
Zero terminated strings for lock names is bad taste. It generates a bunch of
useless strlen executions and you force an ascii namespace for no apparent
reason. Add a 9th parameter, namelen, to the lock call maybe?
Regards,
Daniel
next prev parent reply other threads:[~2005-05-19 6:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-18 22:33 [RFC] [PATCH] OCFS2 Mark Fasheh
2005-05-18 23:35 ` Hans Reiser
2005-05-18 23:40 ` Adrian Bunk
2005-05-19 1:26 ` [Ocfs2-devel] " Manish Singh
2005-05-19 9:45 ` Adrian Bunk
2005-05-19 2:30 ` Kyle Moffett
2005-05-19 4:30 ` Mark Fasheh
2005-05-19 6:30 ` Daniel Phillips [this message]
2005-05-19 6:54 ` Mark Fasheh
2005-05-19 16:23 ` Daniel Phillips
2005-05-19 10:26 ` Jeff Garzik
2005-05-19 15:20 ` Lee Revell
2005-05-19 15:25 ` Jeff Garzik
2005-06-23 18:03 ` James Morris
2005-06-23 18:29 ` Mark Fasheh
2005-06-24 3:05 ` Paul Jackson
2005-06-24 3:29 ` Paul Jackson
2005-06-24 3:59 ` Mark Fasheh
2005-06-24 4:17 ` Paul Jackson
-- strict thread matches above, loose matches on Subject: below --
2005-06-21 21:14 Steve French
2005-06-21 22:03 ` Mark Fasheh
2005-06-21 22:43 ` Steve French
2005-06-22 0:04 ` Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505190230.23624.phillips@istop.com \
--to=phillips@istop.com \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lmb@suse.de \
--cc=mark.fasheh@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=torvalds@osdl.org \
--cc=wim.coekaerts@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).