From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Phillips <phillips@istop.com>
Subject: Re: [RFC] [PATCH] OCFS2
Date: Thu, 19 May 2005 02:30:23 -0400
Message-ID: <200505190230.23624.phillips@istop.com>
References: <20050518223303.GE1340@ca-server1.us.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	ocfs2-devel@oss.oracle.com, torvalds@osdl.org, akpm@osdl.org,
	wim.coekaerts@oracle.com, lmb@suse.de
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from smtp.istop.com ([66.11.167.126]:65490 "EHLO smtp.istop.com")
	by vger.kernel.org with ESMTP id S262215AbVESG0Z (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 19 May 2005 02:26:25 -0400
To: Mark Fasheh <mark.fasheh@oracle.com>
In-Reply-To: <20050518223303.GE1340@ca-server1.us.oracle.com>
Content-Disposition: inline
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Wednesday 18 May 2005 18:33, Mark Fasheh wrote:
> http://oss.oracle.com/projects/ocfs2/dist/files/patches/2.6.12-rc4/broken-o
>ut/06_dlm.patch A distributed lock manager built with the cluster file
> system use case in mind. The OCFS2 dlm exposes a VMS style API, though
> things have been simplified internally. The only lock levels implemented
> currently are NLMODE, PRMODE and EXMODE.

+ if (recovery && 
+     (!dlm_is_recovery_lock(name, strlen(name)) || convert) ) {
+  goto error;
+ }

Zero terminated strings for lock names is bad taste.  It generates a bunch of 
useless strlen executions and you force an ascii namespace for no apparent 
reason.  Add a 9th parameter, namelen, to the lock call maybe?

Regards,

Daniel