From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamie Lokier Subject: Re: [RFC][PATCH] rbind across namespaces Date: Sat, 21 May 2005 14:43:58 +0100 Message-ID: <20050521134358.GA4274@mail.shareable.org> References: <1116627099.4397.43.camel@localhost> <1116660380.4397.66.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Miklos Szeredi , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , viro@parcelfarce.linux.theplanet.co.uk Return-path: Received: from mail.shareable.org ([81.29.64.88]:16090 "EHLO mail.shareable.org") by vger.kernel.org with ESMTP id S261420AbVEUNoI (ORCPT ); Sat, 21 May 2005 09:44:08 -0400 To: Ram Content-Disposition: inline In-Reply-To: <1116660380.4397.66.camel@localhost> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Ram wrote: > > Also why check current->namespace? It doesn't hurt to do > > get_namespace() even if it's not strictly needed. And it would > > simplify the code. > > however get_namespace() will chew up some extra cycles > sometimes unnecessarily. I did incorporate your comment and > got much simpler code. Checking current->namespace also chews up extra cycles, sometimes unnecessarily, but the cycles are negligable in both cases. Because they're negligable, the most important thing is to avoid unnecessary complications in the code. -- Jamie