From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: negative seek offsets in VFS Date: 25 May 2005 18:39:05 +0200 Message-ID: <20050525163905.GP86087@muc.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org Return-path: Received: from colin.muc.de ([193.149.48.1]:25362 "EHLO mail.muc.de") by vger.kernel.org with ESMTP id S261476AbVEYQjG (ORCPT ); Wed, 25 May 2005 12:39:06 -0400 Date: Wed, 25 May 2005 18:39:05 +0200 To: viro@www.linux.org.uk Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org My x86-64 users are complaining again that they cannot reach kernel text addresses in /dev/kmem. The reason is that they are negative and the the VFS read and seek code just EINVALs them. For seek I could fix it in drivers/char/mem.c, but for read/pread/write etc. it needs VFS changes. I dont quite get why they are there anyways, the super block has max file size field and checking against that should be enough for all the filesystems, no? Opinions? -Andi